This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Fix for AMD & Symbol polyfill race condition#255
Open
ndreckshage wants to merge 4 commits intortfeldman:masterfrom
Open
Fix for AMD & Symbol polyfill race condition#255ndreckshage wants to merge 4 commits intortfeldman:masterfrom
ndreckshage wants to merge 4 commits intortfeldman:masterfrom
Conversation
ndreckshage
force-pushed
the
amd-symbol-fix
branch
from
a7d6835 to
ac88f76
Compare
Collaborator
|
@ndreckshage looks reasonable. Can you rebase it on current master, or submit a new PR with only your changes? The CI build has been fixed and additional commits were added to it. And you can either rebuild the conflicting files or leave them out, I will do a build after merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Summary
There is a race condition when using AMD for older browsers that use a Symbol polyfill. https://github.com/rtfeldman/seamless-immutable/blob/7.1.3/src/seamless-immutable.js#L7 this line detects whether a Symbol polyfill is used. However,
immutableInitis called outside ofdefinefor AMD (https://github.com/rtfeldman/seamless-immutable/blob/7.1.3/src/seamless-immutable.js#L742).If a polyfill is in a separate bundle than Seamless, there is a race condition, and if Seamless loads before the polyfill, browsers that use the polyfill crash, because they don't break early on React elements.
Fix
immutableInitinside define, fixing race condition.masterspec's don't pass in CI.