fix firebase sending without additional info#8
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Firebase notification sending issue by ensuring that additional data passed to the Firebase Message is never null and by updating the Firebase configuration for the local environment.
- In NotificationSendingServiceImpl.java, additionalData is now safely defaulted to an empty map when null.
- In FirebaseConfig.java, the active profile was switched to "local" and new timeout settings were added for better connectivity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/ru/randomwalk/twitterservice/service/impl/NotificationSendingServiceImpl.java | Added null safety for additionalData using Objects.requireNonNullElseGet. |
| src/main/java/ru/randomwalk/twitterservice/config/FirebaseConfig.java | Changed active profile to "local" and introduced connection timeout configurations. |
Comments suppressed due to low confidence (1)
src/main/java/ru/randomwalk/twitterservice/config/FirebaseConfig.java:22
- [nitpick] Confirm that switching the profile from '!local' to 'local' is intentional for the intended deployment environment.
@Profile("local")
| .setNotification(notification) | ||
| .setToken(device.getDeviceToken()) | ||
| .putAllData(additionalData) | ||
| .putAllData(Objects.requireNonNullElseGet(additionalData, HashMap::new)) |
There was a problem hiding this comment.
[nitpick] Consider adding a log warning when additionalData is null to help trace cases where expected data is missing.
maksmolchdmitr
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.