Skip to content

WIP: github.com/paulmach/orb#7

Open
gertcuykens wants to merge 1 commit intorubenv:masterfrom
gertcuykens:orb
Open

WIP: github.com/paulmach/orb#7
gertcuykens wants to merge 1 commit intorubenv:masterfrom
gertcuykens:orb

Conversation

@gertcuykens
Copy link
Copy Markdown

@gertcuykens gertcuykens commented Jun 24, 2019

One test I didn't figure out yet, all others are passing

        prequantize_test.go:282: [[[1 1] [1 1]]] != [[[1 1] [1 1] [1 1] [1 1]]]

@gertcuykens gertcuykens force-pushed the orb branch 6 times, most recently from ed0ea48 to 2349b18 Compare June 25, 2019 06:20
@rubenv
Copy link
Copy Markdown
Owner

rubenv commented Jun 25, 2019

This changes the API and is thus not something we can just put into master (it would break current code).

Either we'll have to introduce a v2 or I'd recommend moving this to a new repo, specific for topojson + orb.

@gertcuykens
Copy link
Copy Markdown
Author

Ok, new repo is fine I guess. PS can you maybe collaborate on the one test that is failing? Then I can finish the work on it. As far as I understand, [[[1 1] [1 1]]] is the expected result?

@rubenv
Copy link
Copy Markdown
Owner

rubenv commented Jun 25, 2019

I really can't tell you what is wrong or right there, most of this code was written three years ago and I'll need to figure it all out again. As mentioned previously: unless there's someone sponsoring the work, I won't be working on this.

That being said, this is mostly a port of the JS work done by @mbostock, so you might want to check his original implementation.

@gertcuykens
Copy link
Copy Markdown
Author

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants