るびま lint: リンク文字列末尾の疑問符・感嘆符では全角空白の警告を出さない#641
Merged
Merged
Conversation
… the end of link text
Merged
Contributor
なるほどー...!! |
Contributor
Author
|
確認&マージありがとうございます! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
るびま lint (
editing_tools/rubima-lint.rb)の「疑問符・感嘆符の後には全角空白が必要です。」の warning の出力条件の修正です。リンク文字列末尾に感嘆符(!or?)がある場合に、「疑問符・感嘆符の後には全角空白が必要です。」の warning の出力され、オートコレクトで不要な全角空白が追加されるので、リンク文字列末尾の感嘆符については warning を出力しないように変更しています。
再現手順
以下の sample.md のマークダウンファイルに対して
editing_tools/rubima-lint.rbを実行する。$ bundle exec editing_tools/rubima-lint.rb sample.md期待する挙動
リンク文字列末尾に感嘆符(!)がある場合の4行目で「疑問符・感嘆符の後には全角空白が必要です。」の warning が出力されないこと。
実際の挙動
リンク文字列末尾に感嘆符(!)がある場合の4行目で「疑問符・感嘆符の後には全角空白が必要です。」の warning が出力されること。