Remove currently deprecated functionality#4013
Merged
Merged
Conversation
kddnewton
reviewed
Mar 18, 2026
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Will these rubocop changes work on old versions of RuboCop? Should we just keep the checks?
The method for marking something as deprecated is currently unused but seems fine leave as is.
Earlopain
force-pushed
the
remove-deprecations
branch
from
1c97bf7 to
5b523df
Compare
Collaborator
Author
|
They pin to ~> 1.0 but didn't always. I would guess mixing these older rubocop-ast with newer rubocop versions is broken in some way but it's whatever. |
kddnewton
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly in the node extension. The method for marking something as deprecated is currently unused but seems fine leave as is.