Add comma-separated emails on bulk-email confirm page; rename to "Send bulk emails"#1915
Merged
Conversation
…bulk emails" The comma-separated recipient list on the confirm page existed so an admin could copy addresses into another tool, but it rendered names — useless for that purpose. Switch it to emails. Also rename the menu link and page titles from "Send reminder emails" to "Send bulk emails" since the flow is no longer reminder-specific. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 25, 2026
| <h3 class="text-xs font-semibold uppercase tracking-wide text-gray-500 mb-1">Comma-separated</h3> | ||
| <p class="text-sm text-gray-700 mb-4 break-words"> | ||
| <%= @event_registrations.map { |reg| reg.registrant.full_name }.join(", ") %> | ||
| <%= @event_registrations.map { |reg| reg.registrant.preferred_email }.join(", ") %> |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Switched this from full_name to preferred_email — the "Comma-separated" block exists for copy-pasting addresses, so names were the wrong value. Reusing the same preferred_email accessor already shown in the "Full list" below.
…page Restore the names list (admins still want it) and add a separate emails list alongside it, rather than replacing one with the other. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
The page sits on a tinted domain-theme background, which bled through the inputs. Force bg-white so the editable fields read as editable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Top-level sections are now Recipients, Email draft, and Preview. Subject and message become subheads indented under Email draft, with extra space above the group to separate it from the recipient list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Header with underline now sits above the white content card, mirroring the other sections, with extra spacing around the header and card bottom. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The email HTML uses fixed px sizing, so zoom scales fonts and elements together while still reflowing to the container width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The earlier spacing/hint classes (mt-*, text-xs) weren't in the compiled CSS because Tailwind doesn't rescan ERB on its own, so they served stale. Force a dev build so the utilities actually exist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 👀 Skim — view-only: copy/markup, no logic or data changes
🤖 Generated with Claude Code