Show sector names in their stored casing (filter + story-shares header)#1921
Merged
Conversation
The sector filter dropdown ran every label through .humanize, which
flattened intentionally-cased sector names ("LGBTQIA+" → "Lgbtqia+",
"Child Abuse/Neglect" → "Child abuse/neglect"). Render the label as
stored so the dropdown matches the canonical name shown in the Sectors
admin. Windows audience labels ("Adult"/"Children"/"Combined") are
unaffected since they're already sentence case.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Same casing-distortion class as the workshops filter: .titleize flattened
canonical sector names ("LGBTQIA+" → "Lgbtqia+", "Self-Care/Personal
Growth" → "Self Care/Personal Growth") in the story-shares sector index
header. Render the already-parsed @sector_names_all as-is instead.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 👀 Skim — view-only: removes a
.humanize/.titleizeon two sector labels, no logic or data changesWhat & why
Two display sites distorted intentionally-cased sector names (
"LGBTQIA+","Child Abuse/Neglect","Self-Care/Personal Growth"). Both now render the name as stored, matching the Sectors admin._dropdown_filter.html.erb) — dropped.humanize("LGBTQIA+"→"Lgbtqia+"). The same shared partial feeds the Windows audience filter, whose labels ("Adult"/"Children"/"Combined") are already sentence case and unaffected.story_shares/_sector_index.html.erb) — dropped.titleize; render the already-parsed@sector_names_allinstead.I audited every other sector display site (forms, tag chips, admin, dashboard, decorators) — all already render
sector.nameverbatim, no other offenders.Tests
LGBTQIA+, notLgbtqia+).