Default new affiliations to first of month and unchecked primary contact#1922
Merged
Conversation
Pre-filling today's date and a checked primary-contact box made admins accept defaults that were usually wrong: affiliations are tracked from the start of the month, and most people on an org are not its primary contact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 26, 2026
| input_html: { | ||
| type: "date", | ||
| value: (f.object.start_date || (Date.current unless f.object.persisted?))&.strftime("%Y-%m-%d"), | ||
| value: (f.object.start_date || (Date.current.beginning_of_month unless f.object.persisted?))&.strftime("%Y-%m-%d"), |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Both defaults only apply to unpersisted rows (unless f.object.persisted? for the date; primary_contact? reflects the stored value for existing rows), so editing an existing affiliation is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 👀 Skim — view-only: form default changes in a shared partial, no logic or data changes
What & why
New affiliation rows in the people-edit and org-edit forms now default to:
Both are view-only changes in the shared partial
app/views/affiliations/_fields.html.erb. Existing affiliations still render their stored values; the DB default forprimary_contactwas alreadyfalse.Tests