Collapse additional preferences to two rows with a show more/less link#78
Merged
Conversation
Each category group of additional-preference chips now clips to two rows by default, with an inline "Show more (+N)" / "Show less" link at the end of the last visible row. A new chip-overflow Stimulus controller measures chip positions to decide what to hide and recomputes on resize and when the dialog opens. Groups that already fit in two rows show no link, and a group defaults to expanded when one of its chips is already selected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Resolves four CSS-parsing DoS advisories (GHSA-6jxj-px6v-747w, GHSA-6wmf-3r64-vcwv, GHSA-8vfg-2r28-hvhj, GHSA-wwpr-jff3-395c) flagged by bundler-audit. crass is a transitive dependency of loofah; the bump stays within its ~> 1.0.2 constraint and touches no other gems. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional-preference chips in the allocation modal could grow to many rows per category, making the modal long and noisy. Each category group now clips to two rows by default, with an inline "Show more (+N)" / "Show less" link at the end of the last visible row to reveal or re-collapse the rest. A new
chip-overflowStimulus controller measures chip positions to decide what to hide and recomputes on resize and when the dialog opens (positions aren't measurable while the dialog isdisplay:none). Groups that already fit in two rows show no link, and a category defaults to expanded when one of its chips is already selected. Hidden chips still submit their values, so collapsing never drops a selection.🤖 Generated with Claude Code