Skip to content

Declutter nav bar with a user menu dropdown #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcdragon merged 1 commit into from
Jul 2, 2026
Merged

Declutter nav bar with a user menu dropdown #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/javascript/controllers/dropdown_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { Controller } from "@hotwired/stimulus"

export default class extends Controller {
static targets = ["menu", "trigger"]

toggle() {
this.menuTarget.classList.contains("hidden") ? this.open() : this.close()
}

open() {
this.menuTarget.classList.remove("hidden")
if (this.hasTriggerTarget) this.triggerTarget.setAttribute("aria-expanded", "true")
}

close() {
this.menuTarget.classList.add("hidden")
if (this.hasTriggerTarget) this.triggerTarget.setAttribute("aria-expanded", "false")
}

closeOnOutsideClick(event) {
if (!this.element.contains(event.target)) this.close()
}
}
33 changes: 23 additions & 10 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,30 @@
<% end %>

<div class="ml-auto flex items-center gap-4 text-sm">
<% if Rails.env.development? %>
<%= link_to "Mailer previews", "/rails/mailers", class: "text-ink-soft hover:text-ink" %>
<% end %>
<% if authenticated? %>
<%= link_to "About you", users_story_path, class: "text-ink-soft hover:text-ink" %>
<%= link_to "Explore options", scenarios_path, class: "text-ink-soft hover:text-ink" %>
<% if Current.user&.admin_of?(Current.organization) %>
<%= link_to "Admin Dashboard", admin_dashboard_path, class: "text-ink-soft hover:text-ink" %>
<% end %>
<%= link_to "Profile", users_profile_path, class: "text-ink-soft hover:text-ink" %>
<%= button_to "Sign out", session_path, method: :delete, class: "text-ink-soft hover:text-ink cursor-pointer" %>
<%= link_to "Dashboard", dashboard_path, class: "text-ink-soft hover:text-ink" %>
<div class="relative" data-controller="dropdown"
data-action="click@window->dropdown#closeOnOutsideClick keydown.esc->dropdown#close">
<button type="button" data-action="dropdown#toggle" data-dropdown-target="trigger"
aria-haspopup="true" aria-expanded="false"
class="flex items-center gap-1 text-ink-soft hover:text-ink cursor-pointer">
<%= Current.user&.name.presence || Current.user&.email_address %>
<svg class="h-4 w-4" viewBox="0 0 20 20" fill="none" stroke="currentColor" aria-hidden="true">
<path d="M6 8l4 4 4-4" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round" />
</svg>
</button>
<div data-dropdown-target="menu"
class="hidden absolute right-0 top-full mt-2 w-48 rounded-md border border-line bg-surface py-1 shadow-lg">
<%= link_to "Profile", users_profile_path, class: "block px-4 py-2 text-ink-soft hover:text-ink hover:bg-canvas" %>
<% if Current.user&.admin_of?(Current.organization) %>
<%= link_to "Admin Dashboard", admin_dashboard_path, class: "block px-4 py-2 text-ink-soft hover:text-ink hover:bg-canvas" %>
<% end %>
<% if Rails.env.development? %>
<%= link_to "Mailer previews", "/rails/mailers", class: "block px-4 py-2 text-ink-soft hover:text-ink hover:bg-canvas" %>
<% end %>
<%= button_to "Sign out", session_path, method: :delete, class: "block w-full text-left px-4 py-2 text-ink-soft hover:text-ink hover:bg-canvas cursor-pointer" %>
</div>
</div>
<% elsif Current.organization %>
<%= link_to "Log in", new_session_path, class: "text-ink-soft hover:text-ink" %>
<%= link_to "Explore the legacy builder platform", new_registration_path,
Expand Down
4 changes: 2 additions & 2 deletions test/controllers/dashboards_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ class DashboardsControllerTest < ActionDispatch::IntegrationTest

assert_response :success
assert_select "h1", "Welcome to your workspace"
assert_select "a[href=?]", users_story_path, text: "About you"
assert_select "a[href=?]", scenarios_path, text: "Explore options"
assert_select "a[href=?] h3", users_story_path, text: "About you"
assert_select "a[href=?] h3", scenarios_path, text: "Explore options"
# The nav brand/logo links back to the dashboard for signed-in users.
assert_select "nav a[href=?]", dashboard_path
end
Expand Down
Loading