Strip HTTP Basic-Auth credentials from the URL#85
Merged
Conversation
Loading production via a credentialed URL (https://user:pass@host) leaves the credentials in document.URL. Turbo passes the credential-free URL to history.replaceState(), the browser treats the two as mismatched origins, and throws a SecurityError that cascades and breaks login. Add a Stimulus controller on <body> that detects credentials in location and redirects to the clean URL; the browser has already cached the auth, so the navigation stays authenticated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading production behind the pre-release Basic-Auth lock via a credentialed URL (
https://user:pass@host) leaves the credentials indocument.URL, so when Turbo callshistory.replaceState()with the credential-free URL the browser throws aSecurityErrorthat cascades and breaks login. This adds astrip-url-credentialsStimulus controller on<body>that detects credentials inlocationand redirects to the clean URL; the browser has already cached the auth, so the navigation stays authenticated and Turbo works.🤖 Generated with Claude Code