Skip to content

#5593 product_drive_participants ordered alphabetically#5616

Open
tonleikar wants to merge 1 commit into
rubyforgood:mainfrom
tonleikar:5593-alphabetise-product-drive-participant
Open

#5593 product_drive_participants ordered alphabetically#5616
tonleikar wants to merge 1 commit into
rubyforgood:mainfrom
tonleikar:5593-alphabetise-product-drive-participant

Conversation

@tonleikar

Copy link
Copy Markdown

Resolves #5593

Description

In new donation Product Drive Participants are now sorted alphabetically. They were originally being ordered by contact name in the model. This is now changed to business name. as some participants by only have a contact name they are ordered again in the view by a combination of both. I considered writing some SQL but didn't want to create any trickle down effects and new bugs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified by running app locally, adding new participants and confirming position

@dorner dorner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. There is a validation on ProductDriveParticipant that both contact_name and business_name must be present. So maybe something else is going on here?

There also need to be request tests for this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alphabetize Product Drive Participant dropdown in new-donation form

2 participants