Defer *quicklisp-home* existence check.#29
Merged
Conversation
Check whether *quicklisp-home* exists when we need its value. Defer the ASDF setup so *quicklisp-home* can be set to the right value beforehand.
rudolfochrist
requested changes
Jul 6, 2026
rudolfochrist
left a comment
rudolfochrist
left a comment
Owner
There was a problem hiding this comment.
There is a lot of stuff, but for me it looks like the cleanest approach.
Remove new export to prevent SBCL from complaining about package variance. Move `(ensure-asdf-loaded)` into the `setup` function. Rename `setup-asdf` to `setup`. Remove `*quicklisp-home*` verification. Update documentation.
Load ql-https through ASDF and call the Quicklisp `setup` function. Update documentation for the new change.
Contributor
Author
|
Okay, I think I've got everything in order and it seems to work fine on my end. |
Owner
|
Wow! Thank you very much! |
Contributor
Author
|
You're welcome and thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether
*quicklisp-home*exists when we need its value. Defer the ASDF setup so*quicklisp-home*can be set to the right value beforehand.This is probably a better alternative to probing for a
*quicklisp-home*variable in the CL-USER package.Usecase remains the same: allowing to set a custom
*quicklisp-home*value in the user init file (e.g.~/.sbclrc) without having the Quicklisp set-up error out.