Fix critical bugs + rewrite JavaDoc#10
Merged
runafterasun merged 1 commit intorunafterasun:masterfrom Feb 24, 2026
Merged
Conversation
…JavaDoc
- Fix fillCollection/fillStream: change o.getClass().isAssignableFrom(fill.getClazz())
to fill.getClazz().isAssignableFrom(o.getClass()) so subtype elements are not silently dropped
- Fix getExtendedParameterForField: valueLength fallback now uses fill.getValueLength()
instead of fill.getCollectionSize()
- Rewrite JavaDoc across all core, service, type, and utility classes:
remove blank lines in doc blocks, fix vague descriptions ("split field fill",
"start builder with name"), add missing @param/@return tags, fix copy-paste errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAssignableFromcheck inRandomValue.fillCollection()andRandomValue.fillStream()— elements were dropped whenwrapByFunctionreturned a subtypevalueLengthfallback inRandomValueFieldSetterCallback— was incorrectly falling back tocollectionSizeinstead ofvalueLengthutils/reflection/) — fix blank lines, copy-paste errors, unclear descriptions, and missing class-level documentationTest plan
./gradlew test— all existing tests should passfillCollectionandfillStreamwork correctly with subtype mutations viawrapByFunction./gradlew javadoc— verify no warnings