Enhance mobile decryption functionality - #47
Merged
Conversation
- Updated the `Keys` class to replace the `decrypt_with_network` method with `decrypt_envelope_data`, improving clarity and functionality in mobile decryption processes. - Introduced a new test case for mobile decryption with profile keys, validating the decryption path for user mobile keystores and ensuring compatibility with profile-based encryption. - Enhanced existing tests to cover various scenarios, including multiple valid profile keys and network key fallbacks, ensuring robust validation of the decryption workflows. - Improved logging in tests to provide better insights during execution and confirm successful decryption paths.
- Renamed the `get_network_public_key` function to `has_network_private_key` across multiple modules, enhancing clarity in the API by explicitly indicating the function's purpose. - Updated method signatures and implementations in `runar-ffi`, `runar-keys`, and `runar-nodejs-api` to reflect the new naming convention, ensuring consistency across the codebase. - Adjusted related tests to validate the new functionality, confirming that the checks for private keys are correctly implemented and functioning as expected. - Improved documentation and comments to clarify the changes and their implications for users of the API.
pentateu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keysclass to replace thedecrypt_with_networkmethod withdecrypt_envelope_data, improving clarity and functionality in mobile decryption processes.