Skip to content

[RUN-4638] Migrate publishing from Maven Central to PackageCloud - #456

Merged
Jesus-Osuna-M merged 5 commits into
mainfrom
RUN-4638-publish-to-packagecloud
Jul 21, 2026
Merged

[RUN-4638] Migrate publishing from Maven Central to PackageCloud#456
Jesus-Osuna-M merged 5 commits into
mainfrom
RUN-4638-publish-to-packagecloud

Conversation

@Jesus-Osuna-M

Copy link
Copy Markdown
Contributor

Jira ticket

RUN-4638 (subtask of RUN-4570)

Description

Migrate ansible-plugin publishing from Maven Central (Sonatype) to PackageCloud, applying the same design already validated on rundeck-plugins/sshj-plugin#136 and rundeck-plugins/http-step#60. Part of the RUN-4570 Maven Central publishing limits resolution — plugins account for the bulk of the file/release count on Maven Central, but no external project depends on them as Maven dependencies.

  • Removed nexusPublish/nexusPublishing (Sonatype-specific, dead once release.yml stops calling publishToSonatype).
  • Point the existing PackageCloud maven repo at the configurable PKGCLD_REPO_URL env var (trimmed, and guarded so plain builds/CI without the var don't fail at Gradle configuration time), replacing the hardcoded rundeckpro-test URL left over from an earlier test.
  • Dropped GPG signing: PackageCloud's Maven endpoint rejects the checksum Gradle auto-generates for .asc signature files (422 Unprocessable Entity on *.jar.asc.sha1), and neither the OSS rundeck WAR nor rundeckpro-enterprise WAR carry .asc signatures on PackageCloud either — only RPM/DEB packages are signed there, natively, via the separately-published BUILD-GPG-KEY.
  • release.yml: replaced the "Publish to Maven Central" step with "Publish to PackageCloud".

Testing instructions

  • Merge this PR.
  • Tag a test version to trigger the release workflow (this exact flow — build, sign-free publish, checksums — was validated end-to-end on sshj-plugin 1.0.4: jar/pom/sources/javadoc all publish successfully to PackageCloud).
  • Verify the artifact appears under org/rundeck/plugins/ansible-plugin/<version>/ at whatever repo PKGCLD_REPO_URL points to.
  • Verify ./gradlew build still succeeds without PKGCLD_REPO_URL set (e.g. in gradle.yml CI) — the PackageCloud repo registration is guarded and should not affect plain builds.

Part of RUN-4570: Maven Central publishing limits resolution, applying
the same design validated on rundeck-plugins/sshj-plugin (PR #136) and
rundeck-plugins/http-step (PR #60).

- Remove nexusPublish plugin/nexusPublishing block (Sonatype-specific,
  dead once release.yml stops calling publishToSonatype).
- Point the PackageCloud maven repo at the configurable PKGCLD_REPO_URL
  (trimmed, guarded so plain builds/CI without the var don't fail at
  configuration time) instead of the hardcoded rundeckpro-test URL left
  over from an earlier manual test.
- Drop GPG signing: PackageCloud's Maven endpoint rejects the checksum
  Gradle auto-generates for .asc signature files (422 Unprocessable
  Entity), and neither the OSS rundeck WAR nor rundeckpro-enterprise
  carry .asc signatures on PackageCloud either - only RPM/DEB packages
  are signed there natively.
- release.yml: replace the Sonatype publish step with PackageCloud.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the plugin’s release publishing pipeline from Sonatype/Maven Central to PackageCloud, aligning this repository with the org’s newer release/publishing approach and removing Sonatype-specific configuration.

Changes:

  • Removed Gradle Nexus (Sonatype) publishing configuration from the build.
  • Updated the Gradle publishing repo definition to use a configurable PKGCLD_REPO_URL and PackageCloud auth token.
  • Updated the GitHub Actions release workflow to publish to PackageCloud instead of Maven Central (and dropped signing-related secrets/flags).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
gradle/publishing.gradle Switches publishing repository configuration to a PKGCLD_REPO_URL-driven PackageCloud target and removes signing logic.
build.gradle Removes io.github.gradle-nexus.publish-plugin usage and Sonatype nexusPublishing configuration.
.github/workflows/release.yml Updates the release workflow to publish via Gradle to PackageCloud and wires in PackageCloud configuration/secrets.

Comment thread gradle/publishing.gradle Outdated
Comment thread gradle/publishing.gradle Outdated
Comment thread .github/workflows/release.yml
Addresses GitHub Copilot review feedback on the PackageCloud migration
PRs: without this, a missing PKGCLD_REPO_URL makes the publish task
not exist at all (confusing "task not found"), and a missing
PKGCLD_WRITE_TOKEN with the URL present produces a "Bearer null"
Authorization header that PackageCloud rejects with a non-obvious
401/422. Validate both upfront in the one step that actually needs
them, instead of leaving the Gradle-side guard (which exists to keep
unrelated CI like gradle.yml working without these vars) to surface
the failure indirectly.
Addresses the remaining GitHub Copilot review feedback: default
pkgcldRepoUrl to the real, canonical rundeck-plugins PackageCloud URL
instead of relying on PKGCLD_REPO_URL always being set. This removes
the need for the "only register if URL present" guard entirely, since
uri() never receives null - registering a Maven repository doesn't
make any network call until something actually resolves/publishes
through it, so there's no cost to always registering it.

With the URL guaranteed non-null, release.yml's fail-fast check only
needs to validate PKGCLD_WRITE_TOKEN (which still has no safe public
default, since it's a secret).
Validated end-to-end on rundeck-plugins/sshj-plugin (merged): signing
via sign(publishing.publications) makes Gradle auto-generate a
checksum for every publication artifact including the .asc files
themselves, and PackageCloud's Maven endpoint 422s on the
checksum-of-a-signature-file. Sidestep this entirely by signing the
already-built artifacts with the gpg CLI directly and uploading just
the .asc files via curl, bypassing Gradle's publish/checksum machinery
for this part. Reuses the existing SIGNING_KEY_B64/SIGNING_PASSWORD
secrets (now pointing at a renewed, non-expired key).
@Jesus-Osuna-M Jesus-Osuna-M added this to the 6.2.0 milestone Jul 20, 2026

@ronaveva ronaveva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jesus-Osuna-M
Jesus-Osuna-M enabled auto-merge July 21, 2026 13:39
@Jesus-Osuna-M Jesus-Osuna-M modified the milestone: 6.2.0 Jul 21, 2026
@Jesus-Osuna-M
Jesus-Osuna-M merged commit 540d03f into main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants