Skip to content

RUN-4340: npm dependency overrides and weekly Snyk schedule #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdevans wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RUN-4340: npm dependency overrides and weekly Snyk schedule #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff24f44
fix(security): address npm CVEs in rundeck-cli; schedule weekly Snyk
fdevans Apr 16, 2026
bcbfb89
Merge branch 'main' into cve-fixes
fdevans Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/snyk-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
schedule:
# Weekly on Monday 06:00 UTC (GitHub Actions cron is UTC-only)
- cron: '0 6 * * 1'
workflow_dispatch:

jobs:
Expand Down
23 changes: 13 additions & 10 deletions docker/client/rundeck-cli/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion docker/client/rundeck-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@types/node": "^13.13.5",
"dotenv": "^10.0.0",
"form-data": "^3.0.0",
"js-yaml": "^3.13.2",
"js-yaml": "^3.14.2",
"node-fetch": "^2.6.1",
"ts-node": "^8.10.1",
"ts-rundeck": "^0.1.8",
Expand All @@ -28,8 +28,10 @@
},
"overrides": {
"axios": "1.15.0",
"follow-redirects": "1.16.0",
"tough-cookie": "4.1.3",
"xml-js": "0.5.1",
"xml2js": "0.6.2",
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overrides force major/semver-incompatible versions for transitive deps (e.g., ts-rundeck / @azure/ms-rest-js declare axios: ^0.18.0, tough-cookie: ^2.4.3, xml2js: ^0.4.19, but overrides pin axios@1.15.0, tough-cookie@4.1.3, xml2js@0.6.2). This bypasses the dependents’ declared compatibility ranges and can cause runtime breakage. Prefer upgrading/replacing the upstream dependency to versions that support the newer transitive deps, or scope overrides as narrowly as possible and add a smoke check to validate the CLI still works with the forced versions.

Suggested change
"xml2js": "0.6.2",

Copilot uses AI. Check for mistakes.
"diff": "4.0.4"
}
}
Loading