Open
Conversation
I'm definitely not happy with the current state of it as the goal is to fix runelite#461 and current state of things don't use query parameters. I've tried getting query parameters to work but for some reason I can't seem to figure out how to match the url for those. So I went ahead and started trying to 'solve the issue' this way. I would like to get some feedback and/or help on how to tackle this problem.
Contributor
Author
|
Feels hacky, but it works |
Member
|
This should probably be changed to consume a filter of author and search, I think. It would eliminate a lot of the conditional logic you added. |
Contributor
Author
What would that look like? I don't usually write react. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm definitely not happy with the current state of it as the goal is to fix #461 and current state of things don't use query parameters.
I've tried getting query parameters to work but for some reason I can't seem to figure out how to match the url for those.
So I went ahead and started trying to 'solve the issue' this way.
I would like to get some feedback and/or help on how to tackle this problem.