fix(studio): drop bundled @runflow-io/sdk from peerDependencies#7
Merged
Conversation
The SDK is inlined into the studio dist via tsup noExternal — consumers never install it, so the peer declaration was wrong packaging (flagged by CodeRabbit in #4 review). Concretely it also made changesets bump the studio to 1.0.0 when the sdk took its 0.1.0 minor (peer range ^0.0.3 went out of range). devDependency switched to workspace:* so the build always compiles against the workspace SDK rather than a stale registry version once versions diverge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the packaging inconsistency flagged in #4's review: the SDK is tsup-
noExternalbundled into the studio dist, so the peerDependency was never needed by consumers — and it was actively harmful: changesets major-bumped the studio to 1.0.0 in the auto-generated version PR (#6) because the sdk's 0.1.0 minor left the^0.0.3peer range.@runflow-io/sdk(react/react-dom stay)^0.0.3→workspace:*so the build always compiles against the workspace SDK (a registry^0.0.3would silently pin the OLD sdk once 0.1.0 ships)After merge, the Release workflow regenerates the version PR with studio at 0.1.0 alongside sdk/proxy.
Verified: build 10/10, studio tests green, typecheck + lint green.
🤖 Generated with Claude Code