Open
Conversation
The selector property was dropped from jQuery 3 (see: https://api.jquery.com/selector/). In this instance (the removeError method), there is no need for it in the first place. Instead, we can just use the jQuery object provided (node).
Author
|
Hi @running-coder , seems fairly clear you're no longer actively developing this so not sure whether this PR is helpful but I figured I'd send it over. I'm upgrading my site to jQuery 3 and found some incompatibilities in your library. This was a fairly easy fix, though it looks like there are lots of other instances of I didn't attempt to build the Looks like you removed the Issues section from the Github repo? 😢 I know you mentioned you had planned to rewrite the library in ES6 soon…any updates on that? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selector property was dropped from jQuery 3 (see:
https://api.jquery.com/selector/).
In this instance (the removeError method), there is no need
for it in the first place. Instead, we can just use the
jQuery object provided (node).