Merged
Conversation
…ix date format portability
jhcipar
approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the flash CLI’s output formatting to a compact inline style (reducing rich tables/panels) and introduces shared formatting helpers (status dots + human-readable datetimes). It also changes flash app delete to take the app name as a positional argument.
Changes:
- Replace table/panel-heavy CLI output across commands (
app,env,undeploy,resource,preview,init) with a consistent inline format. - Add
cli.utils.formattinghelpers (state_dot,format_datetime) and update commands to use them. - Update unit tests to validate string output and adjust for the
flash app delete <name>positional argument.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/cli/utils/test_formatting.py | Adds tests for new datetime/status formatting helpers. |
| tests/unit/cli/utils/test_deployment.py | Updates call site for reconcile_and_provision_resources. |
| tests/unit/cli/test_undeploy.py | Updates assertions to match new undeploy messaging/status return shape. |
| tests/unit/cli/test_env.py | Updates tests to assert on printed text rather than Rich Table/Panel. |
| tests/unit/cli/test_apps.py | Updates tests for new inline output + positional arg for app delete. |
| tests/unit/cli/commands/test_resource.py | Renames tested render function and updates patch points. |
| tests/unit/cli/commands/test_init.py | Updates expected init status messaging. |
| src/runpod_flash/core/resources/serverless.py | Lowers an update log line from info to debug. |
| src/runpod_flash/cli/utils/formatting.py | Introduces state_dot + format_datetime. |
| src/runpod_flash/cli/utils/deployment.py | Docstring tweak related to show_progress. |
| src/runpod_flash/cli/commands/undeploy.py | Reworks list/undeploy output into compact inline style + summary helper. |
| src/runpod_flash/cli/commands/resource.py | Replaces table/panel report with inline Text renderable output. |
| src/runpod_flash/cli/commands/preview.py | Replaces preview table with inline container listing + simplified guidance. |
| src/runpod_flash/cli/commands/init.py | Replaces panels/tables with inline project structure + next steps. |
| src/runpod_flash/cli/commands/env.py | Replaces tables/panels with inline environment summaries + sections. |
| src/runpod_flash/cli/commands/build.py | Docstring updated to document verbose summary option. |
| src/runpod_flash/cli/commands/apps.py | Reworks app list/get/delete output and makes delete argument positional. |
| .gitignore | Ignores pytest-results.xml and coverage.xml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes AE-2050
Replaces rich tables, panels, and emoji-heavy formatting with a consistent, compact inline style matching flash deploy and flash build. Plus human-readable dates.
flash app delete now takes a positional argument (matching create/get) instead of requiring --app.