Skip to content

Comments

feat: flash cli polishing treatments#209

Merged
KAJdev merged 23 commits intomainfrom
zeke/ae-2146-flash-worker-polishing-treatments
Feb 20, 2026
Merged

feat: flash cli polishing treatments#209
KAJdev merged 23 commits intomainfrom
zeke/ae-2146-flash-worker-polishing-treatments

Conversation

@KAJdev
Copy link
Contributor

@KAJdev KAJdev commented Feb 19, 2026

Completes AE-2050

Replaces rich tables, panels, and emoji-heavy formatting with a consistent, compact inline style matching flash deploy and flash build. Plus human-readable dates.

flash app delete now takes a positional argument (matching create/get) instead of requiring --app.

image image

@KAJdev KAJdev marked this pull request as ready for review February 19, 2026 23:56
@KAJdev KAJdev requested review from deanq and jhcipar February 19, 2026 23:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the flash CLI’s output formatting to a compact inline style (reducing rich tables/panels) and introduces shared formatting helpers (status dots + human-readable datetimes). It also changes flash app delete to take the app name as a positional argument.

Changes:

  • Replace table/panel-heavy CLI output across commands (app, env, undeploy, resource, preview, init) with a consistent inline format.
  • Add cli.utils.formatting helpers (state_dot, format_datetime) and update commands to use them.
  • Update unit tests to validate string output and adjust for the flash app delete <name> positional argument.

Reviewed changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/unit/cli/utils/test_formatting.py Adds tests for new datetime/status formatting helpers.
tests/unit/cli/utils/test_deployment.py Updates call site for reconcile_and_provision_resources.
tests/unit/cli/test_undeploy.py Updates assertions to match new undeploy messaging/status return shape.
tests/unit/cli/test_env.py Updates tests to assert on printed text rather than Rich Table/Panel.
tests/unit/cli/test_apps.py Updates tests for new inline output + positional arg for app delete.
tests/unit/cli/commands/test_resource.py Renames tested render function and updates patch points.
tests/unit/cli/commands/test_init.py Updates expected init status messaging.
src/runpod_flash/core/resources/serverless.py Lowers an update log line from info to debug.
src/runpod_flash/cli/utils/formatting.py Introduces state_dot + format_datetime.
src/runpod_flash/cli/utils/deployment.py Docstring tweak related to show_progress.
src/runpod_flash/cli/commands/undeploy.py Reworks list/undeploy output into compact inline style + summary helper.
src/runpod_flash/cli/commands/resource.py Replaces table/panel report with inline Text renderable output.
src/runpod_flash/cli/commands/preview.py Replaces preview table with inline container listing + simplified guidance.
src/runpod_flash/cli/commands/init.py Replaces panels/tables with inline project structure + next steps.
src/runpod_flash/cli/commands/env.py Replaces tables/panels with inline environment summaries + sections.
src/runpod_flash/cli/commands/build.py Docstring updated to document verbose summary option.
src/runpod_flash/cli/commands/apps.py Reworks app list/get/delete output and makes delete argument positional.
.gitignore Ignores pytest-results.xml and coverage.xml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

KAJdev and others added 6 commits February 20, 2026 12:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@KAJdev KAJdev merged commit 93bc347 into main Feb 20, 2026
6 checks passed
@KAJdev KAJdev deleted the zeke/ae-2146-flash-worker-polishing-treatments branch February 20, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants