Fix: runpodctl send/receive "room (secure channel) not ready" error#214
Closed
acamq wants to merge 10 commits intorunpod:mainfrom
Closed
Fix: runpodctl send/receive "room (secure channel) not ready" error#214acamq wants to merge 10 commits intorunpod:mainfrom
acamq wants to merge 10 commits intorunpod:mainfrom
Conversation
The receiver was missing critical configuration options that the sender was setting, causing "room (secure channel) not ready" errors: - Added DisableLocal: true to match sender - Added HashAlgorithm: "xxhash" to ensure same hashing algorithm - Added RelayPorts to connect to the same relay ports This configuration mismatch prevented sender and receiver from establishing a secure channel on the relay server. Fixes channel negotiation errors when using runpodctl send/receive.
…-015V6LZiuJWBGuX8TopyGEhC Fix croc channel error by matching sender/receiver configuration
The root cause of the "room not ready" error was that sender and receiver were using completely different croc implementations: - Sender: Used local forked implementation (cmd/croc/croc.go) - Receiver: Used external library (github.com/schollz/croc/v9/src/croc) This fundamental mismatch caused incompatible channel negotiation. Changes: - Changed receiver to use local Options type instead of croc.Options - Changed receiver to call local New() instead of croc.New() - Added ZipFolder: true to match sender configuration - Removed import of external croc library Now both sender and receiver use the same local implementation, ensuring compatible configuration and channel setup.
…-015V6LZiuJWBGuX8TopyGEhC Fix receiver to use local croc implementation matching sender
Contributor
|
Thank you for the report! Your assessment was correct and this has been fixed in release 1.14.15-dac76ad - this will be rolling out to the production environment this week. Fixed release: https://github.com/runpod/runpodctl/releases/tag/v1.14.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using runpodctl send/recieve resulted in this error:
But using croc directly worked fine.
The sender and receiver were using fundamentally different croc implementations:
The receiver now uses the local fork of the croc implementation. Additionally, missing configuration options were added to the receiver side.
How I tested it
Built on Zorin OS 18 with Linux kernel 6.14.0-33-generic, x86_64. Tested by sending and receiving files to and from a pod.