refactor: extract shutdown timeout magic numbers to constants#11
Open
bianbiandashen wants to merge 1 commit into
Open
refactor: extract shutdown timeout magic numbers to constants#11bianbiandashen wants to merge 1 commit into
bianbiandashen wants to merge 1 commit into
Conversation
- Add GRACEFUL_SHUTDOWN_TIMEOUT_MS (10 seconds) - Add SHUTDOWN_POLL_INTERVAL_MS (100ms) - Makes the shutdown behavior more self-documenting and easier to tune
ADD-SP
reviewed
Feb 14, 2026
Comment on lines
+9
to
+14
| /// Maximum time to wait for graceful shutdown before sending SIGKILL (in milliseconds). | ||
| const GRACEFUL_SHUTDOWN_TIMEOUT_MS: u64 = 10_000; | ||
|
|
||
| /// Interval between checks when waiting for process to exit (in milliseconds). | ||
| const SHUTDOWN_POLL_INTERVAL_MS: u64 = 100; | ||
|
|
Collaborator
There was a problem hiding this comment.
It is best to use const variables of type std::time::Duration here.
ADD-SP
force-pushed
the
main
branch
2 times, most recently
from
April 12, 2026 17:00
798e737 to
87955a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop_process()to named constantsGRACEFUL_SHUTDOWN_TIMEOUT_MS = 10_000(10 seconds total wait)SHUTDOWN_POLL_INTERVAL_MS = 100(polling interval)Why
Changes
src/process.rsTest plan