fix: add macOS support for process uptime retrieval#14
Open
bianbiandashen wants to merge 1 commit into
Open
Conversation
The get_process_uptime() function was using Linux-specific /proc filesystem, which doesn't exist on macOS. This adds a macOS-specific implementation using `ps -o etime=` command. Changes: - Split get_process_uptime into platform-specific implementations - Add parse_etime() to parse ps etime output format on macOS - Add macOS-specific unit tests for etime parsing - Update test_get_process_uptime_self to work on both platforms
ADD-SP
force-pushed
the
main
branch
2 times, most recently
from
April 12, 2026 17:00
798e737 to
87955a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_process_uptime()function/proc/{pid}/stat)ps -o etime=on macOS to get elapsed timeWhy
The existing implementation relied on the Linux-specific
/procfilesystem, which doesn't exist on macOS. This causedget_process_uptime()to always returnNoneon macOS.Changes
src/process.rs:get_process_uptimeintoget_process_uptime_linuxandget_process_uptime_macosusing#[cfg]parse_etime()function to parsepsoutput format ([[DD-]HH:]MM:SS)test_get_process_uptime_selfto work on both platformsTest plan