Farm#31
Closed
stewartshea wants to merge 5 commits into
Closed
Conversation
… for improved clarity in descriptions and aliases.
…t imports of AWS_ACCOUNT_NAME for improved clarity and consistency. Update related templates to include AWS_ACCOUNT_NAME variable.
…with account name for improved clarity. Modify related templates to include AWS_ACCOUNT_NAME variable, enhancing consistency across the codebase.
…tead of account ID references, enhancing clarity and maintainability. Update related templates to ensure uniformity across the codebase.
- Rename existing Dockerfile (codecollection-devtools-based, used for the devcontainer / IDE workflow) to Dockerfile.devcontainer and point .devcontainer.json at it. - Add new production Dockerfile based on rw-base-runtime as the CCV build target (replaces the external build-system pipeline). - Add .github/workflows/build-push.yaml: parallel native amd64/arm64 build matrix (ubuntu-latest + ubuntu-24.04-arm), push-by-digest with buildx imagetools manifest merge, catalog-compatible tag schema <sanitized_ref>-<cc_sha7>-<rt_sha7>. Builds on push to any branch and on PRs; paths-ignore skips docs-only diffs. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
Contributor
Author
|
Closing in favor of #33. This branch had drifted ~3 months from GitHub's PR diff renders by replaying every unique commit, so this PR showed 40 files of changes even though only 4 files actually differed at HEAD between #33 contains only the CCV-build commit, rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes the production container base image and adds new automated multi-arch build/push + tagging logic, which could affect runtime compatibility and release publishing. Also updates multiple AWS codebundles to require/provide
AWS_ACCOUNT_NAME, which could break runs if that variable isn’t populated by the platform.Overview
Build/release pipeline: Adds a new
build-pushGitHub Actions workflow that builds nativeamd64/arm64images, runs a smoke test, pushes per-arch digests to GHCR, and then merges them into a multi-arch manifest with a new tag scheme (<ref>-<cc_sha7>-<rt_sha7>plus aliases likelatest/pr-<n>). Adds a scheduled/manualreleaseworkflow to generate date-based GitHub releases.Containerization/dev tooling: Updates the production
Dockerfileto build fromghcr.io/runwhen-contrib/rw-base-runtime(with an overridableBASE_IMAGEarg) and splits local dev into a newDockerfile.devcontainer, updating.devcontainer.jsonto use it.AWS codebundles: Across several
aws-c7n-*bundles, switches SLX/SLI descriptions and Robot task titles to use the human-friendlymatch_resource.account_name, and threads a newAWS_ACCOUNT_NAMEconfig/user variable through templates and suite initialization (removing ad-hoc account-name lookup in some suites).Reviewed by Cursor Bugbot for commit 62bb9e5. Bugbot is set up for automated code reviews on this repo. Configure here.