Skip to content

Add tunnel support to run and lift processing#40

Merged
russellporter merged 1 commit intorussellporter:masterfrom
pranet:feature/tunnel-support
Mar 5, 2026
Merged

Add tunnel support to run and lift processing#40
russellporter merged 1 commit intorussellporter:masterfrom
pranet:feature/tunnel-support

Conversation

@pranet
Copy link
Contributor

@pranet pranet commented Mar 5, 2026

Parses the OSM tunnel tag on piste and aerialway/railway ways and exposes it in RunProperties, LiftProperties, and their MapboxGL counterparts. Updates test fixtures to include the new required tunnel field.

See: https://wiki.openstreetmap.org/wiki/Key:tunnel

Tested using

docker compose exec app npm run check-types 
docker compose exec app npm test  

package.json Outdated
"ngeohash": "^0.6.3",
"object-hash": "^3",
"openskidata-format": "^10.0.0",
"openskidata-format": "git+https://github.com/pranet/openskidata-format.git#feature/tunnel-support",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this after russellporter/openskidata-format#4 is merged.

@nocommit

Copy link
Owner

@russellporter russellporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I've released the format lib (v11) now

Parses the OSM tunnel tag on piste and aerialway/railway ways and
exposes it in RunProperties, LiftProperties, and their MapboxGL
counterparts. Updates test fixtures to include the new required
tunnel field.

See: https://wiki.openstreetmap.org/wiki/Key:tunnel

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pranet pranet force-pushed the feature/tunnel-support branch from 0916033 to 6ccd884 Compare March 5, 2026 18:02
@pranet
Copy link
Contributor Author

pranet commented Mar 5, 2026

Ready to be merged

@russellporter russellporter merged commit 1a51300 into russellporter:master Mar 5, 2026
@russellporter
Copy link
Owner

thanks! The data should be updated on the nightly run within the next 12 hrs

@pranet
Copy link
Contributor Author

pranet commented Mar 6, 2026

Hmn not seeing the tunnel tags on prod website yet. Did the nightly run finish?

@russellporter
Copy link
Owner

Yes the run failed yesterday. However today's run worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants