Backport 188 serde deserialization bug#202
Merged
apoelstra merged 2 commits intorust-bitcoin:0.2.xfrom Mar 3, 2026
Merged
Conversation
PR rust-bitcoin#188 fixes issue rust-bitcoin#189. This is a manual backport, less changes needed than the original. Just the test, the fix, and uptade the `serde_json` dev dependency. Other changes in the original patch were not needed.
Merged
The macro is defined in this file and also imported?? Just remove the incorrect import. And waste a bunch of my life fixing the pinning in `contrib/test.sh`.
tcharding
force-pushed
the
push-uruyxounlwwz
branch
from
666dfa0 to
14b4bab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #188 fixes issue #189. This is a manual backport, less changes needed than the original. Just the test, the fix, and uptade the
serde_jsondev dependency. Other changes in the original patch were not needed.Requires fix to pinning in CI (which uses the very old ci script on this branch). Whinge, whinge, whinge.