Skip to content

Vec::from_array now const #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tower120 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Vec::from_array now const #644

tower120 wants to merge 12 commits into from
+104 −22

Conversation

@tower120
Copy link

@tower120 tower120 commented Jan 28, 2026 •
edited
Loading

Implements #643

zeenix
zeenix requested changes Jan 28, 2026
View reviewed changes
@tower120
Copy link
Author

tower120 commented Jan 29, 2026 •
edited
Loading

@zeenix Do you see these comments?
image

UPDATE: Sorry - it turns out "pending" means pending MY approval to send review comments.
I initially thought it was "pending" for maintainer approval to make them visible for everyone.

tower120
tower120 commented Jan 29, 2026
View reviewed changes
@rust-embedded rust-embedded deleted a comment from tower120 Jan 29, 2026
sgued
sgued requested changes Jan 29, 2026
View reviewed changes
@tower120
Copy link
Author

tower120 commented Jan 29, 2026

BTW, why explicit u64 is not supported as LenType?

@tower120
Copy link
Author

tower120 commented Jan 29, 2026

Also, I see in some places LenType is lentype, in other it is len_type.
Which convention should I follow?

@sgued
Copy link
Contributor

sgued commented Jan 30, 2026

u64 doesn't make much sense because usize would always be a better option.

@sgued
Copy link
Contributor

sgued commented Jan 30, 2026

You should use len_type. We should probably unify it everywhere to LenType and len_type removing lentype which doesn't match Rust's naming conventions.

@tower120
Copy link
Author

tower120 commented Jan 30, 2026

OK. Then everything good as it is.

@tower120 tower120 requested review from sgued and zeenix January 30, 2026 09:36
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
tower120 and others added 2 commits January 30, 2026 18:16
@tower120 @reitermarkus
Apply suggestion from @reitermarkus
1283c09 
Co-authored-by: Markus Reiter <me@reitermark.us>
@tower120
SAFETY comments added
e930cc6
@tower120 tower120 requested a review from reitermarkus January 30, 2026 16:43
@tower120
Copy link
Author

tower120 commented Feb 6, 2026

So, do you need something from my side to move this forward?

zeenix
zeenix reviewed Feb 7, 2026
View reviewed changes
@zeenix zeenix enabled auto-merge February 7, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeenix zeenix zeenix approved these changes

@sgued sgued Awaiting requested review from sgued

@reitermarkus reitermarkus Awaiting requested review from reitermarkus

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tower120 @sgued @zeenix @reitermarkus