This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Open
Conversation
This prevents construction of this variant.
Author
|
It should be noted that if there is a crate A that depends on |
Contributor
|
Can you help me understand the use case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents construction of this variant.
Use a hidden public wrapper over
void::Voidfor 2 reasons:voiddependency in Cargo.toml to useerror-chain.void::Void.Alternatively,
error-chaincan define its ownenum Void {}to bring down amount of dependencies (as a rather fundamental crate, more dependencies can lead to issues, in my opinion).Technically, this is a breaking change because
__Nonexhaustivein 0.11.0 can still be used. If compatibility is a concern,voidcan be made an optional dependency and disabled by default - then 0.11.1 will only add a Cargo feature without breaking changes.