Add completions for cargo remove#11204
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 10, 2022
Merged
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cassaundra
force-pushed
the
remove-completions
branch
from
8a3ccc5 to
dfbf3e6
Compare
Contributor
Author
|
Added missing |
cassaundra
force-pushed
the
remove-completions
branch
from
dfbf3e6 to
3b6d2c4
Compare
Member
|
For whom wants to test this completion zsh: # under cargo project directory
fpath+=$PWD/src/etc
autoload -Uz compinit
compinit
# test it
cargo rm <tab>bash # install any bash completion from your distro and source their init script
# e.g. brew install bash-completion && . "/path/to/pbash_completion.sh"
# under cargo project directory
. ./src/etc/cargo.bashcomp.sh
# test it
cargo rm <tab> |
weihanglo
approved these changes
Oct 10, 2022
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
Member
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
weihanglo
pushed a commit
to weihanglo/cargo
that referenced
this pull request
Oct 10, 2022
…anglo Add completions for `cargo remove` ### What does this PR try to resolve? This PR continues the deferred work of rust-lang#11099 by adding bash and zsh completions for the cargo remove subcommand. ### How should we test and review this PR? There doesn't seem to be much in the way of testing for these completions automatically, so I would suggest verifying that they work in practice and sufficiently cover the subcommand's surface area. ### Additional Information I will also soon post a PR for cargo remove's documentation.
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Oct 11, 2022
9 commits in 3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3..b8f30cb23c4e5f20854a4f683325782b7cff9837 2022-10-07 17:34:03 +0000 to 2022-10-10 19:16:06 +0000 - Add more doc comments for three modules (rust-lang/cargo#11207) - docs: fix (rust-lang/cargo#11208) - Add completions for `cargo remove` (rust-lang/cargo#11204) - Config file loaded via CLI takes priority over env vars (rust-lang/cargo#11077) - Use `#[default]` when possible (rust-lang/cargo#11197) - Implement RFC 3289: source replacement ambiguity (rust-lang/cargo#10907) - Use correct version of cargo in test (rust-lang/cargo#11193) - Check empty input for login (rust-lang/cargo#11145) - Add retry support to sparse registries (rust-lang/cargo#11069)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2022
Update cargo 9 commits in 3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3..b8f30cb23c4e5f20854a4f683325782b7cff9837 2022-10-07 17:34:03 +0000 to 2022-10-10 19:16:06 +0000 - Add more doc comments for three modules (rust-lang/cargo#11207) - docs: fix (rust-lang/cargo#11208) - Add completions for `cargo remove` (rust-lang/cargo#11204) - Config file loaded via CLI takes priority over env vars (rust-lang/cargo#11077) - Use `#[default]` when possible (rust-lang/cargo#11197) - Implement RFC 3289: source replacement ambiguity (rust-lang/cargo#10907) - Use correct version of cargo in test (rust-lang/cargo#11193) - Check empty input for login (rust-lang/cargo#11145) - Add retry support to sparse registries (rust-lang/cargo#11069)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR continues the deferred work of #11099 by adding bash and zsh completions for the cargo remove subcommand.
How should we test and review this PR?
There doesn't seem to be much in the way of testing for these completions automatically, so I would suggest verifying that they work in practice and sufficiently cover the subcommand's surface area.
Additional Information
I will also soon post a PR for cargo remove's documentation.