Add support for -fno-plt#351
Merged
alexcrichton merged 1 commit intorust-lang:masterfrom Sep 28, 2018
Merged
Conversation
fd59191 to
e16de19
Compare
Contributor
Author
|
Uh, I've run into a problem: how do I check if |
Member
|
Hm so unfortunately |
e16de19 to
bf17fc1
Compare
Contributor
Author
|
@alexcrichton Ok, I've made it so that this flag is not enabled by default. Another alterantive would've been to look at GCC's / Clang's version directly, and hard-code a version check, but it looks like we don't retrieve the compiler's version at any point. |
Member
|
Ok thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to rust-lang/rust#54592, this PR enables the
-fno-pltcompiler flag by default when PIC is used. Should provide a small performance improvement with no obvious downsides.