add support for thumbv7a-pc-windows-msvc#78
Merged
alexcrichton merged 2 commits intorust-lang:masterfrom May 14, 2019
chandde:master
Merged
add support for thumbv7a-pc-windows-msvc#78alexcrichton merged 2 commits intorust-lang:masterfrom chandde:master
alexcrichton merged 2 commits intorust-lang:masterfrom
chandde:master
Conversation
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This is Chandler from Microsoft working on enabling ARM32 for Azure IoTEdge, which has a module is written in rust, we have already enabled ARM32 in rust tool chain (rust-lang/rust#53621), although there is some missing dependency in LLVM so ARM is not officially supported yet in official release, we're using a private version of cargo and rustc to compile Azure IoTEdge in ARM already, check out https://github.com/Azure/iotedge/blob/master/edgelet/build/windows/build.ps1#L30. Besides addressing ARM in rust, we also need to update a few crates to support ARM, e.g. backtrace-rs, winapi, cmake-rs, etc..
This is a simple change inside function visual_studio_generator to unblock this new build string. Please take a look.
Thanks
Chandler