Conversation
Contributor
Author
|
apple-darwin is also failing on master |
Member
|
👍 |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
Ported from upstream musl commit 4f3d346bffdf9ed2b1803653643dc31242490944 Fixes rust-lang#263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @alexcrichton in rust-lang/rust#56066 (comment) and rust-lang/rust#56066 (comment).
This also adds f32 versions of acosf, asinf, atan2f, atanf, cbrtf, coshf, expm1f, fdimf, hypotf, log1pf, sinhf, tanf, tanhf to the wasm target. These have recently been implemented. With this change, the conversion functions in https://github.com/rust-lang/rust/blob/b74215a/src/libstd/sys/wasm/cmath.rs#L11-L75 are obsolete and can be swapped out for their f32 versions. I have included that change in my SGX PR for std which updates the compiler-builtins submodule.