session: Drop GET support for the OAuth endpoints#13833
Open
Turbo87 wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Turbo87
force-pushed
the
session-drop-get
branch
2 times, most recently
from
4dcc4e1 to
ee88ae8
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
No live client issues `GET` requests against this endpoint anymore, so the deprecated variant is removed, leaving `POST` as the only method.
No live client issues `GET` requests against this endpoint anymore, so the deprecated variant and its query-string parameter struct are removed, leaving `POST` with its JSON body as the only method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13829, which added
POSTvariants of the GitHub OAuth session endpoints and kept the existingGETroutes as deprecated, backward-compatible shims. This removes thoseGETshims, leavingPOSTas the only method on both/api/private/session/beginand/api/private/session/authorize. Each commit drops one endpoint's shim along with its tests, and regenerates the OpenAPI snapshot and the API-client schema.This must not be deployed until #13829 has been live in production long enough that no client still issues
GETrequests to these endpoints. TheGETshims only exist to cover stale, browser-cached copies of the frontend. Dropping them before those copies have cycled out would break login for the affected users until they reload. The PR stays in draft until then.Related
POSTon the OAuth endpoints #13829