Use shallow clones for the worker index repository#13864
Open
Turbo87 wants to merge 1 commit into
Open
Conversation
The worker's long-lived index clone only ever reads the current tip and commits/pushes on top of it, so it does not need the full index history. This adds an opt-in `Repository::open_shallow()` fn that clones with `--depth 1` and keeps `reset_head()` fetches shallow. It is used from the worker's `lock_index()` fn. The full-history `Repository::open()` is unchanged so the `upload-index` admin tool's incremental mode keeps working.
Turbo87
added
the
C-internal 🔧
Member
Author
|
I've tried this out on the staging server: 
→ rust-lang/staging.crates.io-index@e1e8cf4 but with 14 commits (now 15) on the staging index, that isn't quite representative in terms of performance. The commit creation and pushing works though, and we could still revert if this turns out to be a performance regression in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker's long-lived index clone only ever reads the current tip and commits/pushes on top of it, so it does not need the full index history.
This adds an opt-in
Repository::open_shallow()fn that clones with--depth 1and keepsreset_head()fetches shallow. It is used from the worker'slock_index()fn. The full-historyRepository::open()is unchanged so theupload-indexadmin tool's incremental mode keeps working.