move log config to struct, support disabling stdout for builds#3203
Merged
GuillaumeGomez merged 1 commit intorust-lang:mainfrom Feb 12, 2026
Merged
move log config to struct, support disabling stdout for builds#3203GuillaumeGomez merged 1 commit intorust-lang:mainfrom
GuillaumeGomez merged 1 commit intorust-lang:mainfrom
Conversation
d875c1e to
a74a1ee
Compare
GuillaumeGomez
approved these changes
Feb 12, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is triggered by @marcoieni asking us for logging less to syslog for cost reasons.
Especially the build logs inside
rustwide::logging::captureare also stored on S3, so we don't need to additionally log them to stdout.While I'm on it, move the logging config to a config struct.