add workspace lints, forbid dbg! usage, remove current usages#3204
Merged
GuillaumeGomez merged 1 commit intorust-lang:mainfrom Feb 13, 2026
Merged
add workspace lints, forbid dbg! usage, remove current usages#3204GuillaumeGomez merged 1 commit intorust-lang:mainfrom
GuillaumeGomez merged 1 commit intorust-lang:mainfrom
Conversation
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Feb 13, 2026
Member
|
Thanks! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after not having the build-logs in the cratesfyi log stream I saw that I actually left a
dbg!macro call in one of the main web handlers...Of course this contributes quite much to our currently high log usage.
To be very save, this adds config for workspace lints, and sets
warnfordbg!andtodo!(we have-D warningsinjust lint)I also removed them in tests for now, while there is
allow-dbg-in-tests, I couldn't quickly figure out how to best have a workspace-levelclippy.toml.