Enable specialization with aHash#207
Conversation
|
This uses aHash 0.5.1 which no longer depends on const-random by default. See tkaitchuck/aHash@980159d |
|
CI is failing. |
|
This is running into an issue with In the current version per the discussion in: tkaitchuck/aHash#48 aHash does not supply a |
|
@Amanieu Does this approach make sense? My concern is that it is something of a downgrade for |
|
Right now if both flags are off I have it doing: |
|
I think the current behavior is fine. Using constant keys should also improve performance a bit. |
|
This failed on thumbv6m-none-eabi apparently because atomics are not available on |
|
@Amanieu Please take another look. I believe this approach is a lot better. |
|
Remaining build issue is a pre-existing problem: #214 |
|
LGTM once the CI issues are fixed. |
|
☔ The latest upstream changes (presumably #215) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
This uses the specialization feature in nightly to improve performance for hashing some classes (u8, u16, u32, u64, u128, [u8], and String) For these classes it improves performance by 15% the test
insert_ahashbenchmarks.