ipcheck: Drop the "Rust (New)" implementation#318
Merged
dtolnay merged 1 commit intorust-lang:mainfrom Jan 21, 2024
Merged
Conversation
There have been no substantial changes in implementation of various Rust's IpAddr helper methods (is_loopback() etc.) that I can think of. The PR[1] that the "Rust (New)" implementation was based on has been closed in May 2021, I think it's safe to say it's no longer relevant and doesn't help anyone. [1] rust-lang/rust#76098
Contributor
Author
|
So, I wasn't quite sure what to do about this. On one hand the "Rust (New)" implementation ipcheck provided some historical context, on the other I don't think it matters anymore. Submitting the PR for your consideration. |
29 tasks
dtolnay
approved these changes
Jan 21, 2024
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thank you. I agree with your impression — I don't see this being valuable to keep around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been no substantial changes in implementation of various Rust's IpAddr helper methods (is_loopback() etc.) that I can think of.
The PR[1] that the "Rust (New)" implementation was based on has been closed in May 2021, I think it's safe to say it's no longer relevant and doesn't help anyone.
[1] rust-lang/rust#76098