libunwind changes needed to run code in sgx environment via rust-sgx.#63
Closed
AdrianCX wants to merge 1 commit intorust-lang:rustc/10.0-2020-05-05from
AdrianCX:rustc/10.0-2020-05-05-rust-sgx-libunwind
Closed
libunwind changes needed to run code in sgx environment via rust-sgx.#63AdrianCX wants to merge 1 commit intorust-lang:rustc/10.0-2020-05-05from AdrianCX:rustc/10.0-2020-05-05-rust-sgx-libunwind
AdrianCX wants to merge 1 commit intorust-lang:rustc/10.0-2020-05-05from
AdrianCX:rustc/10.0-2020-05-05-rust-sgx-libunwind
Conversation
Code is guarded via defines to enable only if 'RUST_SGX' is present. Main logic is in libunwind/src/AddressSpace.hpp We use 6 symbols to figure out where eh_frame / eh_frame_hdr is at runtime when loaded in an SGX enclave. (EH symbols + IMAGE base) These are set by 'fortanix-sgx-tools'. As notes: - Target above at the moment uses a pre-compiled libunwind.a from forked repo. - Goal of these changes is to use official llvm with patch. - Changes in rust-lang to use this are planned if/when this is accepted. - Ticket: fortanix/rust-sgx#174 - Original ported changes: llvm/llvm-project@release/5.x...fortanix:release/5.x
vext01
added a commit
to vext01/llvm-project
that referenced
this pull request
Apr 27, 2023
63: Kill some dead code in the control point pass. r=ltratt a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated branch in response to: #57 (comment)
Please advise on process as this is the first PR against rust-lang's llvm and I tried to follow instructions as close as possible..
Ticket: fortanix/rust-sgx#174
Description: libunwind changes needed to run code in sgx environment via rust-sgx.
Target that uses this in rust: x86_64-fortanix-unknown-sgx.
Rust-lang PR depends on this - plan is to raise it if this PR is accepted.
Without this change, rust std for this toolchain is forced to use a precompiled library loaded via environment variable.
Code is guarded via defines to enable only if 'RUST_SGX' is present.
Main logic is in libunwind/src/AddressSpace.hpp
We use 6 symbols to figure out where eh_frame / eh_frame_hdr is at runtime when loaded in an SGX enclave. (EH symbols + IMAGE base)
These are set when elf is converged to sgx format by 'fortanix-sgx-tools'.
Original ported changes: llvm/llvm-project@release/5.x...fortanix:release/5.x