Closed
Conversation
Collaborator
|
Personally I would be against this change. I don't think it adds any benefits to the log messages, usually the lines numbers themselves are enough, I rarely see two log statements on the same line. Furthermore it would increase the binary sizes, something that people have been trying to reduce lately, see #569 and #575 for example. |
Contributor
|
Thanks for looking into this @printfn. I agree with @Thomasdezeeuw that we should be careful of adding more automatic data into log records. This is (one of the many) case we could support with structured logging, which we've just been discussing stabilizing in #328. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds column numbers to logs, using the
column!macro.