Conversation
… overoptimize compile time.
Also refactor the `mdBook test` section and add a new "writing doc tests" chapter.
|
I'm dependent on feature file_set_times, which was stabilized in rust v 1.76. You are currently on 1.74. What is the schedule for updating your MSRV? |
… project: changed config rust.package-dir to rust.manifest
and preferring [rust.manifest] over [rust.edition].
make chap Alternate Backends pass doctest.
|
Functionally, I think this PR is now stable and ready for review (and general use). |
Prefer edition setting from Cargo.toml over book.toml; sadly, Cargo also overrides command line.
|
|
||
| - [Installation](installation.md) | ||
| - [Reading Books](reading.md) | ||
| - [Creating a Book](creating.md) |
|
In fixing above issues, I noticed that there were clippy nags in several files that hadn't been raised by CI. I've fixed the ones in files I modified and could fix the remaining ones if needed, but I don't know why CI doesn't flag them. |
This comment has been minimized.
This comment has been minimized.
|
@bobhy ^ |
|
Will refresh the PR in a couple of weeks!
…On Mon, Oct 6, 2025, 8:26 PM Berkus Decker ***@***.***> wrote:
*berkus* left a comment (rust-lang/mdBook#2503)
<#2503 (comment)>
@bobhy <https://github.com/bobhy> ^
—
Reply to this email directly, view it on GitHub
<#2503 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPBIZCRYZW4BLZKUE64WN33WKX45AVCNFSM6AAAAABTKIKTLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZTGI2TINRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'd appreciate some feedback on this PR. It adds a kind of nice feature, but maybe needs some more work? It's getting old, simply resolving merge conflicts... |
|
It really is a bummer that we're not able to reference 3rd-party crates. any chance we can get a maintainer have a review and ship this feature anytime soon? |
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
All merged and ready for review. |
5 participants
Allows doc tests to freely reference external crates in
usestatements.Avoids depending on unstable Cargo interfaces to determine dependencies by the
simple expedient of running a
cargo build --verboseand observing how Cargo invoked the compiler.Includes necessary doc changes and some gratuitous rewrites as well.
Fixes #706 and #394.
Edit: does not address issue 768.
Edit: With the latest batch of commits, all doctests in the
mdbookproject now work.