add the help (?) button to the menu#2762
Open
szabgab wants to merge 2 commits intorust-lang:masterfrom
Open
Conversation
* connect to the help popup trigger code * add the configuration option to show the help icon * only set the event listener if the icon is there
quencs
approved these changes
Aug 5, 2025
quencs
approved these changes
Aug 8, 2025
quencs
approved these changes
Aug 8, 2025
Collaborator
|
☔ The latest upstream changes (possibly 21f2435) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Sounds like a good idea. Why adding an option to disable it though? |
Contributor
Author
|
Why not? Some authors might want a "cleaner menu" |
Contributor
Author
|
And I am still trying to figure out how to include the svg version of the icon |
Member
Sure, but then the overall coherency is reduced.
You can use the one in rustdoc. |
This comment was marked as off-topic.
This comment was marked as off-topic.
quencs
approved these changes
Aug 31, 2025
This comment was marked as spam.
This comment was marked as spam.
quencs
approved these changes
Sep 8, 2025
quencs
approved these changes
Sep 14, 2025
quencs
approved these changes
Sep 14, 2025
Contributor
|
@quencs Please stop. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
quencs
approved these changes
Sep 15, 2025
quencs
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier for the first-time reader to find the available keyboard shortcuts.