Support for HTML Renderer to honor .gitignore#2991
Open
benfalk wants to merge 2 commits intorust-lang:masterfrom
Open
Support for HTML Renderer to honor .gitignore#2991benfalk wants to merge 2 commits intorust-lang:masterfrom
.gitignore#2991benfalk wants to merge 2 commits intorust-lang:masterfrom
Conversation
The Watcher and Poller already respected `.gitignore` files when monitoring for changes; however, the HTML Renderer did not. This update ensures that the HTML Renderer also honors `.gitignore`. This prevents ignored files from being processed and included in the generated HTML output. I noticed this when working on a project where the mdbook source directory was the root of the project. mdBook was taking a long time to copy the entire contents of the `target` directory into the book which was gigabytes in size. After this change, the HTML renderer correctly ignored the `target` directory as specified in the `.gitignore` file, significantly speeding up the build process.
Collaborator
|
☔ The latest upstream changes (possibly a3550f9) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Watcher and Poller already respected
.gitignorefiles when monitoring for changes; however, the HTML Renderer did not. This update ensures that the HTML Renderer also honors.gitignore. This prevents ignored files from being processed and included in the generated HTML output.I noticed this when working on a project where the mdbook source directory was the root of the project. mdBook was taking a long time to copy the entire contents of the
targetdirectory into the book which was gigabytes in size. After this change, the HTML renderer correctly ignored thetargetdirectory as specified in the.gitignorefile, significantly speeding up the build process.