Fix current page detection for clean URLs#2993
Open
qaqland wants to merge 1 commit intorust-lang:masterfrom
Open
Fix current page detection for clean URLs#2993qaqland wants to merge 1 commit intorust-lang:masterfrom
qaqland wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
qaqland
force-pushed
the
current-page-active
branch
2 times, most recently
from
bee3fca to
1404b89
Compare
Previously, the sidebar JavaScript logic for detecting the "active" page relied on URL and assumed it would end with .html. When using clean URLs without this suffix, this logic would fail to correctly highlight the current page in the sidebar. This change moves the current page identification to server-side rendering by adding a data-current-link attribute to the HTML root element. Fixes rust-lang#2962
qaqland
force-pushed
the
current-page-active
branch
from
1404b89 to
4d0d4e5
Compare
Contributor
Author
|
@ehuss , could you please review this when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the sidebar JavaScript logic for detecting the "active" page relied on URL and assumed it would end with .html. When using clean URLs without this suffix, this logic would fail to correctly highlight the current page in the sidebar.
This change moves the current page identification to server-side rendering by adding a data-current-link attribute to the HTML root element.
Fixes #2962