fix: pretty url toc highlighting#3028
Open
bens-schreiber wants to merge 2 commits intorust-lang:masterfrom
Open
fix: pretty url toc highlighting#3028bens-schreiber wants to merge 2 commits intorust-lang:masterfrom
bens-schreiber wants to merge 2 commits intorust-lang:masterfrom
Conversation
Author
|
It would be fair to say this is a server side problem and shouldn't be catered to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some static website hosting services (like Cloudflare Pages) reroute URLs to "pretty URLs", removing things like the
.htmlsuffix, breaking the table of contentsactivehighlighting.This fix compares the current page to the active page, ignoring the
.htmlsuffix.See https://cloesce.pages.dev for an example of the TOC highlighting failing (works only on the index page)