Handle short reads and writes for TCP sockets#5023
Open
WhySoBad wants to merge 1 commit intorust-lang:masterfrom
Open
Handle short reads and writes for TCP sockets#5023WhySoBad wants to merge 1 commit intorust-lang:masterfrom
WhySoBad wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As mentioned in #5005, this pull request adds handling for short reads and writes on TCP sockets.
Because short reads/writes imply an empty/full buffer on Unix hosts, we need to remove the readiness in those cases. On Windows hosts, we need to forcefully emit a new readiness event to prevent applications relying on this behavior from being stuck forever.
The
tcp_echotest would not finish with the current implementation, thus I adjusted this test case and added it here, to ensure that it finishes with the new handling.