Import #[repr(transparent)] docs from the Unstable book#353
Closed
SimonSapin wants to merge 1 commit intorust-lang:masterfrom
Closed
Import #[repr(transparent)] docs from the Unstable book#353SimonSapin wants to merge 1 commit intorust-lang:masterfrom
SimonSapin wants to merge 1 commit intorust-lang:masterfrom
Conversation
… as the feature is ready for stabilization: rust-lang/rust#43036 (comment)
|
I don't think this text really fits into the reference, as it explains a lot of motivation and background rather than precisely and concisely stating what the attribute does. Certainly when I wrote it I had something like The Book or RBE in mind, not the reference. |
This was referenced Jun 6, 2018
Author
|
Feature stabilization PR: rust-lang/rust#51395 I agree that the subsections do not necessarily belong there as-is but I wasn’t sure what else to do, this PR is sort of a straw man. |
SimonSapin
added a commit
to SimonSapin/rust
that referenced
this pull request
Jun 12, 2018
Tracking issue FCP: rust-lang#43036 (comment) Reference PR: rust-lang/reference#353
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 16, 2018
Stabilize #[repr(transparent)] Tracking issue FCP: #43036 (comment) Reference PR: rust-lang/reference#353
Contributor
|
I agree that this is not ready for integration into the reference. Adding more/confusing text is not necessarily better, even if it improves coverage. |
Contributor
|
Closing in favor of #389 since the RFC's contents don't translate to being in the reference directly that well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… as the feature is ready for stabilization: rust-lang/rust#43036 (comment)