proc-macro-test: Pass target to cargo invocation#15385
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 23, 2023
Merged
Conversation
When cross compiling macos → dragonfly the dist build fails in the proc-maro-test-impl crate with the following error: ld: unknown option: -z\nclang: error: linker command failed with exit code 1 (use -v to see invocation) This appears to be a wart stemming from using an Apple host for cross compiling. Passing the target along to cargo allows it to pick up a linker that it understands and DTRT.
rustbot
added
the
S-waiting-on-review
Member
|
@bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Aug 4, 2023
…eykril proc-macro-test: Pass target to cargo invocation When cross compiling macos → dragonfly the dist build fails in the proc-maro-test-impl crate with the following error: `ld: unknown option: -z\nclang: error: linker command failed with exit code 1 (use -v to see invocation)` This appears to be a wart stemming from using an Apple host for cross compiling. Passing the target along to cargo allows it to pick up a linker that it understands and DTRT.
Contributor
|
💥 Test timed out |
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Aug 5, 2023
…eykril proc-macro-test: Pass target to cargo invocation When cross compiling macos → dragonfly the dist build fails in the proc-maro-test-impl crate with the following error: `ld: unknown option: -z\nclang: error: linker command failed with exit code 1 (use -v to see invocation)` This appears to be a wart stemming from using an Apple host for cross compiling. Passing the target along to cargo allows it to pick up a linker that it understands and DTRT.
Contributor
|
💔 Test failed - checks-actions |
Member
|
Not sure why CI is failing here tbh |
Author
@Veykril Is there any way to get an actual error message from that build? |
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Aug 23, 2023
…eykril proc-macro-test: Pass target to cargo invocation When cross compiling macos → dragonfly the dist build fails in the proc-maro-test-impl crate with the following error: `ld: unknown option: -z\nclang: error: linker command failed with exit code 1 (use -v to see invocation)` This appears to be a wart stemming from using an Apple host for cross compiling. Passing the target along to cargo allows it to pick up a linker that it understands and DTRT.
Contributor
|
💔 Test failed - checks-actions |
Member
|
@inferiorhumanorgans no need to do anything, I'll try to deal with this later. |
Member
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Member
|
changelog internal (first contribution) pass target in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross compiling macos → dragonfly the dist build fails in the proc-maro-test-impl crate with the following error:
ld: unknown option: -z\nclang: error: linker command failed with exit code 1 (use -v to see invocation)This appears to be a wart stemming from using an Apple host for cross compiling. Passing the target along to cargo allows it to pick up a linker that it understands and DTRT.