Skip to content

Conversation

@Ddystopia
Copy link
Contributor

  • feat: allow local absolute paths
  • feat: allow measuring against multiple crates

I'm not as familiar with PGO, do I understand correctly that by running more commands, more measurements do accumulate and then get merged?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2026
@Ddystopia
Copy link
Contributor Author

One possible improvement would be to report error in case the string passed to --pgo is an absolute path but doesn't exists.

* feat: allow local absolute paths
* feat: allow measuring against multiple crates
@ChayimFriedman2
Copy link
Contributor

Do you actually need this, or just thought this is nice to have?

@Ddystopia
Copy link
Contributor Author

Well I used it to compile RA to better suit my projects. Does this count as "I actually need this"?

@ChayimFriedman2
Copy link
Contributor

Was there a measurable benefit?

@Ddystopia
Copy link
Contributor Author

I didn't benchmark it, I'll try to do this in a span of two weeks

@ChayimFriedman2
Copy link
Contributor

The reason I ask is that I suspect there won't be any perf benefit from customizing to a project (all rust projects look the same, when looking at the level of branch and cache predictions), therefore I don't want to accept this just because.

@Ddystopia
Copy link
Contributor Author

Yeah, I get the point, but my objective is that my projects are quite different as it is either wasm front-ends or embedded software with lots of automatically generated FFI bindings and ra often just dies. I would try to benchmark it against stock ra if there would be some significant benefit.

@lnicola
Copy link
Member

lnicola commented Feb 3, 2026

See #19585 (comment), or better, run your own numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants